Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-2589: [Python] Workaround regression in Pandas 0.23.0 #2051

Closed
wants to merge 1 commit into from
Closed

ARROW-2589: [Python] Workaround regression in Pandas 0.23.0 #2051

wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented May 16, 2018 •
edited
Loading

There is a regression (*) in Pandas 0.23.0 that breaks test_parquet.py.
Pandas does not have an actual "str" dtype anyway, so pass "object" instead.

(*) pandas-dev/pandas#21083

@pitrou
Copy link
Member Author

pitrou commented May 16, 2018 •
edited
Loading

Another possible fix is to replace the "str" dtype with "object", since "str" seemed to be a synonym of "object" before Pandas 0.23.0.

@TomAugspurger what do you think?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented May 16, 2018 •
edited
Loading

For test-code like in https://travis-ci.org/apache/arrow/jobs/379652352#L3156, that should be a fine workaround for now.

In the future when pandas has a dedicated string type, object and str will no longer be synonymous.

pandas-dev/pandas#8640 for tracking that (it may happen soon).

@pitrou
ARROW-2589: [Python] Workaround regression in Pandas 0.23.0
b581ef3 
There is a regression (*) in Pandas 0.23.0 that breaks test_parquet.py.
Pandas does not have an actual "str" dtype anyway, so pass "object" instead.

(*) pandas-dev/pandas#21083
@pitrou pitrou changed the title ARROW-2589: [CI] Avoid Pandas 0.23.0 ARROW-2589: [Python] Workaround regression in Pandas 0.23.0 May 16, 2018
@codecov-io
Copy link

Codecov Report

Merging #2051 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
+ Coverage   87.44%   87.47%   +0.02%     
==========================================
  Files         189      178      -11     
  Lines       29374    28601     -773     
==========================================
- Hits        25686    25018     -668     
+ Misses       3688     3583     -105
Impacted Files Coverage Δ
cpp/src/arrow/util/thread-pool-test.cc 98.87% <0%> (-0.57%) ⬇️
rust/src/builder.rs
rust/src/list.rs
rust/src/memory.rs
rust/src/error.rs
rust/src/buffer.rs
rust/src/memory_pool.rs
rust/src/datatypes.rs
rust/src/bitmap.rs
rust/src/array.rs
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca246a...b581ef3. Read the comment docs.

xhochy
xhochy approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 5bb3d85 May 16, 2018
@pitrou pitrou deleted the ARROW-2589 branch May 16, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pitrou @TomAugspurger @codecov-io @xhochy